Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device_type_linux to workspace_access_properties #20462

Merged
merged 14 commits into from
Aug 9, 2021
Merged

Add device_type_linux to workspace_access_properties #20462

merged 14 commits into from
Aug 9, 2021

Conversation

dhinus
Copy link
Contributor

@dhinus dhinus commented Aug 6, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17553.
Closes #18352.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsWorkspacesDirectory_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspacesDirectory_basic -timeout 180m
=== RUN   TestAccDataSourceAwsWorkspacesDirectory_basic
=== PAUSE TestAccDataSourceAwsWorkspacesDirectory_basic
=== CONT  TestAccDataSourceAwsWorkspacesDirectory_basic


--- PASS: TestAccDataSourceAwsWorkspacesDirectory_basic (499.03s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       500.848s

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesDirectory_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory_basic -timeout 180m
=== RUN   TestAccAwsWorkspacesDirectory_basic
=== PAUSE TestAccAwsWorkspacesDirectory_basic
=== CONT  TestAccAwsWorkspacesDirectory_basic
--- PASS: TestAccAwsWorkspacesDirectory_basic (639.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       641.048s

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesDirectory_workspaceAccessProperties'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory_workspaceAccessProperties -timeout 180m
=== RUN   TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== CONT  TestAccAwsWorkspacesDirectory_workspaceAccessProperties
--- PASS: TestAccAwsWorkspacesDirectory_workspaceAccessProperties (708.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       710.210s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 6, 2021
github-actions[bot]
github-actions bot reviewed Aug 6, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dhinus 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 6, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 7, 2021
ewbankkit and others added 13 commits August 8, 2021 08:07
@ewbankkit
Serialize Workspaces tests: r/aws_workspaces_directory.
51e6712
@ewbankkit
Serialize Workspaces tests: r/aws_workspaces_ip_group.
35d16a5
@ewbankkit
Serialize Workspaces tests: r/aws_workspaces_workspace.
1303aa7
@ewbankkit
Serialize Workspaces tests: d/aws_workspaces_bundle.
739cf42
@ewbankkit
Serialize Workspaces tests: d/aws_workspaces_directory.
a206533
@ewbankkit
Serialize Workspaces tests: d/aws_workspaces_image.
0590cb1
@ewbankkit
Serialize Workspaces tests: d/aws_workspaces_workspace.
c812c2d
@ewbankkit
r/aws_workspaces_ip_group: Add test sweeper.
3b1125f
@ewbankkit
r/aws_workspaces_directory: Retry on 'InvalidResourceStateException' …
811c7de 
…when deregistering.
@dhinus @ewbankkit
Add device_type_linux to workspace_access_properties
b140eeb
@ewbankkit
Add CHANGELOG entry.
79f7ec0
@ewbankkit
r/aws_workspaces_directory: Retry on 'InvalidResourceStateException' …
1010a9e 
…when registering.
@ewbankkit
Modify the signature of the function passed to 'tfresource.RetryWhen'.
2560562
@github-actions github-actions bot added the service/synthetics Issues and PRs that pertain to the synthetics service. label Aug 8, 2021
ewbankkit
ewbankkit approved these changes Aug 8, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSWorkspaces_serial/Directory/basic'                                               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSWorkspaces_serial/Directory/basic -timeout 180m
=== RUN   TestAccAWSWorkspaces_serial
=== RUN   TestAccAWSWorkspaces_serial/Directory
=== RUN   TestAccAWSWorkspaces_serial/Directory/basic
--- PASS: TestAccAWSWorkspaces_serial (833.57s)
    --- PASS: TestAccAWSWorkspaces_serial/Directory (833.57s)
        --- PASS: TestAccAWSWorkspaces_serial/Directory/basic (833.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	837.925s
% make testacc TESTARGS='-run=TestAccDataSourceAwsWorkspaces_serial/Directory/basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspaces_serial/Directory/basic -timeout 180m
=== RUN   TestAccDataSourceAwsWorkspaces_serial
=== RUN   TestAccDataSourceAwsWorkspaces_serial/Directory
=== RUN   TestAccDataSourceAwsWorkspaces_serial/Directory/basic
--- PASS: TestAccDataSourceAwsWorkspaces_serial (703.79s)
    --- PASS: TestAccDataSourceAwsWorkspaces_serial/Directory (703.79s)
        --- PASS: TestAccDataSourceAwsWorkspaces_serial/Directory/basic (703.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	706.885s
% make testacc TESTARGS='-run=TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories -timeout 180m
=== RUN   TestAccAWSWorkspaces_serial
=== RUN   TestAccAWSWorkspaces_serial/IpGroup
=== RUN   TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories
--- PASS: TestAccAWSWorkspaces_serial (775.07s)
    --- PASS: TestAccAWSWorkspaces_serial/IpGroup (775.07s)
        --- PASS: TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories (775.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	778.253s

@ewbankkit
Copy link
Contributor

@dhinus Thanks for the contribution 🎉 👏.
I changed the Workspaces acceptance tests to be serial as we are seeing errors like

== RUN   TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== CONT  TestAccAwsWorkspacesDirectory_workspaceAccessProperties
resource_aws_workspaces_directory_test.go:285: Step 1/1 error: Error running apply: exit status 1
Error: DirectoryLimitExceededException: Directory limit exceeded. A maximum of 10 directories may be created. : RequestId: 47be73e8-3f71-4b9a-86a2-7c898a7aafec
{
RespMetadata: {
StatusCode: 400,
RequestID: "47be73e8-3f71-4b9a-86a2-7c898a7aafec"
},
Message_: "Directory limit exceeded. A maximum of 10 directories may be created. : RequestId: 47be73e8-3f71-4b9a-86a2-7c898a7aafec",
RequestId: "47be73e8-3f71-4b9a-86a2-7c898a7aafec"
}
on terraform_plugin_test.tf line 49, in resource "aws_directory_service_directory" "main":
49: resource "aws_directory_service_directory" "main" {
--- FAIL: TestAccAwsWorkspacesDirectory_workspaceAccessProperties (211.69s)

in CI.

@ewbankkit ewbankkit closed this Aug 8, 2021
@ewbankkit ewbankkit reopened this Aug 8, 2021
@ewbankkit ewbankkit merged commit 8539d1b into hashicorp:main Aug 9, 2021
@github-actions github-actions bot added this to the v3.54.0 milestone Aug 9, 2021
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.54.0
2 participants
@dhinus @ewbankkit